Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assertion should check for encrypted.label of the defined fileSystem #29756

Merged
merged 1 commit into from Sep 29, 2017
Merged

assertion should check for encrypted.label of the defined fileSystem #29756

merged 1 commit into from Sep 29, 2017

Conversation

garbas
Copy link
Member

@garbas garbas commented Sep 24, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@garbas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @KoviRobi and @oxij to be potential reviewers.

@garbas
Copy link
Member Author

garbas commented Sep 25, 2017

i suppose i should also cherrypick this into coming 17.09

@joachifm joachifm mentioned this pull request Sep 29, 2017
Closed
8 tasks
@garbas garbas merged commit 748ef34 into NixOS:master Sep 29, 2017
@garbas garbas deleted the fix-encrypted-assertion branch September 29, 2017 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garbas @mention-bot