radicale: fix default version #29743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@infinisil, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @aneeshusa and @globin to be potential reviewers. |
aneeshusa
reviewed
Sep 24, 2017
There was a problem hiding this comment.
Tested this locally on the release-17.09 branch and this does fix the failing tests in #28643, thanks! Also tested with my local configurations and those continue to work (same hashes).
IMO the parameters to versionAtLeast should have been flipped to make it more useful for partial application, but it's too late to change that easily now.
aneeshusa
approved these changes
Sep 24, 2017
joachifm
pushed a commit
that referenced
this pull request
Sep 25, 2017
(cherry picked from commit a8c97ad)
Nadrieril
pushed a commit
to Nadrieril/nixpkgs
that referenced
this pull request
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am quiet ashamed of myself, because in #27826 I mixed up the arguments of
versionAtLeastand I only noticed now. This should now make the radicale test, which got extended in #29521 by @aneeshusa, succeed for 17.09. I'm not sure why it worked in master.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)