Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirt: Add qemu to runtime closure #29750

Closed
wants to merge 1 commit into from

Conversation

KaiHa
Copy link
Contributor

@KaiHa KaiHa commented Sep 24, 2017

The program qemu-img is needed during creation of virtual machines
with qcow2 images. Otherwise creation of such VMs (e.g. with
virt-manager) are failing.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The program `qemu-img` is needed during creation of virtual machines
with qcow2 images. Otherwise creation of such VMs (e.g. with
virt-manager) are failing.
@mention-bot
Copy link

@KaiHa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @techhazard, @volth and @rickynils to be potential reviewers.

@bjornfor
Copy link
Contributor

Applied to master (32e4e2c). I'll backport later today. Thanks!

@bjornfor bjornfor closed this Sep 25, 2017
@KaiHa KaiHa deleted the libvirt-qemu-fix branch September 25, 2017 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants