meliae: init at 0.4.0 #30508
Merged
meliae: init at 0.4.0 #30508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
xvapx
force-pushed
the
meliae-init
branch
2 times, most recently
from
8b9eedf
to
4c8d306
Compare
FRidh
requested changes
Oct 18, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -11650,6 +11650,10 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| meliae = if ! isPy3k then | |||
There was a problem hiding this comment.
use disabled = isPy3k; in the expression instead
There was a problem hiding this comment.
Fixed, thanks. I've squashed both changes and --force pushed.
| sha256 = "16gcgjzcjlbfarwlj18fn089bz34kzfw8varbzxsi9ma0amijrcp"; | ||
| }; | ||
|
|
||
| checkInputs = [ cython ]; |
There was a problem hiding this comment.
Not needed if it is already in propagatedBuildInputs
FRidh
requested changes
Oct 18, 2017
|
@FRidh Fixed and squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To update Tribler from 7.0.0-rc2 to 7.0.0-rc3 we need this new dependency
Things done
Added meliae 0.4.0 to pyhonPackages.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)