mailnag: use setup.py #30501
mailnag: use setup.py #30501
Conversation
|
/cc @Mic92 |
|
might be also interesting what is going wrong here, so we can fix this in future. |
| @@ -31,6 +33,10 @@ pythonPackages.buildPythonApplication rec { | |||
| pygobject3 dbus-python pyxdg | |||
| ]; | |||
|
|
|||
| buildPhase = ""; | |||
|
|
|||
| installPhase = "python2 setup.py install --prefix=$out"; | |||
There was a problem hiding this comment.
Is this really needed? Our default builder builds wheels and installs those.
There was a problem hiding this comment.
Can you explain what does not work correctly? What happens? Have you mentioned this issue upstream, considering building wheels is the way forward.
There was a problem hiding this comment.
@FRidh
In mailnag-config plugins are not seen, then when closing mailnag-config it should start mailnag, but it can't with error No such file or directory: 'IOError: [Errno 2] No such file or directory: '/usr/share/applications/mailnag.desktop'.
Then starting mailnag manually and trying to send email myself - there should be libnotify notification but there is none.
These things are not happening when these buildPhase and installPhase are here.
This is the patching setup.py does https://github.com/pulb/mailnag/blob/master/setup.py#L22
There was a problem hiding this comment.
Which is an upstream issue pypa/setuptools#130
(Note the name iElectric, that's '@'domenkozar )
There was a problem hiding this comment.
@FRidh Ok. What would be the temporary fix? Because at this stage the package is broken.
ghost
requested a review
from 
Motivation for this change
Revert back to use of setup.py which does some hidden patching. Otherwise plugins not seen in configurator and probably other bugs.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)