fetchgit: Comprehensive valid reference check. #1612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we're matching git's definition of a valid reference.
|
Replaces #1611 |
shlevy
force-pushed
the
fetchgit-check-ref-format
branch
from
464bc5a
to
a470d4b
Compare
|
Why is it important that we match git's notion of a reference? Won't we just get an error eventually if we pass an invalid ref? |
|
Probably. I'm not sure what will happen if the passed in ref has a : or some other special git characters though, maybe it's fine |
|
#1614 just removes the check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we're matching git's definition of a valid reference.