Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many packages used in computer animation industry #30503

Merged
merged 7 commits into from Oct 19, 2017
Merged

Many packages used in computer animation industry #30503

merged 7 commits into from Oct 19, 2017

Conversation

guibou
Copy link
Contributor

@guibou guibou commented Oct 17, 2017 •
edited

Motivation for this change

All of these packages are standard in rendering / animation / cinema industry:

  • ptex : texture loading
  • alembic : asset description
  • partio : particules description
  • openfx : post processing filters
  • openexrid : post processing
  • openvdb : voxel modelisation

We are using nix to build our product: http://guerillarender.com/ which depends on theses libs. I wanted to upstream this work.

These packages are created with our setup in mind, for example, I did not included the openvdb binaries or documentation. I'm motivated to take maintainership of these packages and improve them as needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@guibou guibou requested a review from edolstra as a code owner October 17, 2017 11:37
grahamc
grahamc reviewed Oct 17, 2017
View reviewed changes
pkgs/development/libraries/openexrid/default.nix Outdated
version = "2017-09-17";

src = fetchurl {
url = "https://github.com/MercenariesEngineering/openexrid/archive/bec0081548a096f9bcdd1504970c96264b0fc050.zip";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fetches may be better with fetchFromGitHub

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And actually it was written inside CONTRIBUTING.md. Sorry, I'm fixing that.

@guibou
Copy link
Contributor Author

guibou commented Oct 17, 2017

I corrected the fetchurl to fetchFromGitHub and rebuilt everything. The travis CI was also complaining about a type in license versus licenses which is now fixed.

@guibou
Copy link
Contributor Author

guibou commented Oct 17, 2017

The build failed for macOS integration. I don't have the resource to work this out (i.e: a computer with macOS). Should I change the architecture of the erroneous package or should we tag it as "broken" in some way?

rycee
rycee reviewed Oct 17, 2017
View reviewed changes
pkgs/development/libraries/openexrid/default.nix Outdated

stdenv.mkDerivation rec
{
name = "openexrid-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the package naming guidelines I believe the name here should be openexrid-unstable-${version}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected. Thank you.

@edolstra
Copy link
Member

Looks good to me, thanks!

@guibou guibou force-pushed the guibou_vfx_pkgs branch 2 times, most recently from ea410d1 to 1c5d307 Compare October 17, 2017 17:35
vyp
vyp suggested changes Oct 18, 2017
View reviewed changes
pkgs/development/libraries/alembic/default.nix Outdated
license = {
fullName = "Alembic License";
url = "https://github.com/alembic/alembic/blob/master/LICENSE.txt";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bsd3 license is it not?

pkgs/development/libraries/openfx/default.nix Outdated
license = {
fullName = "OpenFX license";
url = "https://github.com/ofxa/openfx/blob/master/Support/LICENSE";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bsd3?

pkgs/development/libraries/partio/default.nix Outdated
license = {
fullName = "Partio software";
url = "http://wdas.github.io/partio/doxygen/license.html";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bsd3?

pkgs/development/libraries/ptex/default.nix Outdated
license = {
fullName = "Ptex License";
url = "http://ptex.us/documentation.html";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bsd3?

@guibou
Copy link
Contributor Author

guibou commented Oct 18, 2017

As requested by @vyp, I changed the license to bsd3 when applicable.

@FRidh FRidh merged commit d854b3d into NixOS:master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

@vyp vyp vyp requested changes

@rycee rycee rycee approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@guibou @edolstra @grahamc @rycee @vyp @FRidh @Janik-Haag