Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmr-stak-cpu: init at 1.3.0 #30511

Closed
wants to merge 1 commit into from
Closed

Conversation

nico202
Copy link
Contributor

@nico202 nico202 commented Oct 17, 2017

Motivation for this change

Package missing. It's an alt-coin (monero) pool miner, so I don't know if it suits here or in misc.
Also, I don't know how to ensure that the donationLevel parameter is a double. I'm passing it as a string for now

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 17, 2017

Its looks for its configuration in the same directory

$ find /nix/store/9wmy1qpw8qrp94s0mvh3rdbpxi1gz68k-xmr-stak-cpu-1.3.0/
/nix/store/9wmy1qpw8qrp94s0mvh3rdbpxi1gz68k-xmr-stak-cpu-1.3.0/
/nix/store/9wmy1qpw8qrp94s0mvh3rdbpxi1gz68k-xmr-stak-cpu-1.3.0/bin
/nix/store/9wmy1qpw8qrp94s0mvh3rdbpxi1gz68k-xmr-stak-cpu-1.3.0/bin/xmr-stak-cpu
/nix/store/9wmy1qpw8qrp94s0mvh3rdbpxi1gz68k-xmr-stak-cpu-1.3.0/bin/config.txt
$ xmr-stak-cpu
[2017-10-17 17:04:39] : Failed to open config file config.txt.

This needs to be fixed otherwise config.txt cannot be changed.

@nico202
Copy link
Contributor Author

nico202 commented Oct 17, 2017 via email

@Mic92
Copy link
Member

Mic92 commented Oct 17, 2017

At the least config.txt should not be in $out/bin.

homepage = https://github.com/fireice-uk/xmr-stak-cpu;
maintainers = [stdenv.lib.maintainers.nico202];
inherit version;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the license to meta: license = stdenv.lib.licenses.gpl3;.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

description = "Universal Stratum pool miner (CPU version)";
homepage = https://github.com/fireice-uk/xmr-stak-cpu;
maintainers = [stdenv.lib.maintainers.nico202];
inherit version;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@nico202
Copy link
Contributor Author

nico202 commented Oct 30, 2017

Placed the config under etc/xmr-stak-cpu.config.txt. I don't know if keeping it config.txt is okay, or if I need to rename it to template-config.txt or else

@nico202
Copy link
Contributor Author

nico202 commented Nov 21, 2017

Closing since they moved to a new repo with more architecture (cuda/opencl...) here: https://github.com/fireice-uk/xmr-stak

@nico202 nico202 closed this Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants