Document ASTNode#symbolize #5081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
reviewed
Oct 5, 2017
src/compiler/crystal/macros.cr
Outdated
| # {{ "foo".symbolize }} | ||
| # end | ||
| # | ||
| # puts test # prints "foo" (including the double quotes) |
There was a problem hiding this comment.
Maybe is cleaner to show {{ "foo".symbolize }} == :"\"foo\"" # => true.
I am not 100% why the double quotes are included in the symbol value though.
There was a problem hiding this comment.
I was wondering the same :) @asterite, would you please tell us why❓
There was a problem hiding this comment.
The textual representation of "foo" is "foo", and so a symbol with "foo" is :"\"foo\". If you want :foo you need to do "foo".id.symbolize.
There was a problem hiding this comment.
Also "foo".stringify makes a string literal out of that, so it becomes "\"foo\"". The two methods are similar.
Sija
force-pushed
the
macros-astnode-stringify-docs
branch
from
0d7efe8
to
8063ae8
Compare
|
@bcardiff updated code example to match eye expectations (though usage of |
bcardiff
approved these changes
Oct 6, 2017
RX14
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA, couldn't find it in the docs so went ahead and fixed it up :)