Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dd-agent: fix multiple tags in the config file #30141

Merged
merged 1 commit into from Oct 5, 2017
Merged

dd-agent: fix multiple tags in the config file #30141

merged 1 commit into from Oct 5, 2017

Conversation

cleverca22
Copy link
Contributor

@cleverca22 cleverca22 commented Oct 5, 2017 •
edited

Motivation for this change

the tags must be seperated by comma+space not just comma

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cleverca22 added a commit to input-output-hk/iohk-ops that referenced this pull request Oct 5, 2017
@cleverca22
temporarily fix datadog tags until fix is merged upstream
eda2e6b 
related: NixOS/nixpkgs#30141
@cleverca22 cleverca22 mentioned this pull request Oct 5, 2017
Merged
@orivej orivej merged commit 27ab6f0 into NixOS:master Oct 5, 2017
@cleverca22 cleverca22 deleted the fix-datadog-tags branch October 6, 2017 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cleverca22 @orivej