Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the "if" conditions into the "case" expressions #5080

Merged
merged 2 commits into from
Oct 14, 2017
Merged

Integrate the "if" conditions into the "case" expressions #5080

merged 2 commits into from
Oct 14, 2017
+67 −77

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Oct 5, 2017

We can incorporate the "if" conditions that check the existence of the variable into the "case" expressions to improve readability.

@j8r j8r changed the title Integrate the if conditions in the case expressions Integrate the "if" conditions in the "case" expressions Oct 5, 2017
@j8r j8r changed the title Integrate the "if" conditions in the "case" expressions Integrate the "if" conditions into the "case" expressions Oct 5, 2017
@j8r
Copy link
Contributor Author

j8r commented Oct 5, 2017 •
edited
Loading

I also see that the compile command is deprecated since 2016/06/30, maybe it's also the time to delete its entry definitely.

@asterite asterite merged commit 3ff8e59 into crystal-lang:master Oct 14, 2017
@asterite asterite added this to the Next milestone Oct 14, 2017
@j8r j8r deleted the if-clean branch October 15, 2017 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite

@RX14 RX14

Assignees
No one assigned
Labels
breaking-change kind:refactor topic:compiler
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j8r @asterite @RX14