Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdeApplication: kill unused file kde-locale-5.nix #30132

Merged
merged 1 commit into from Oct 30, 2017
Merged

kdeApplication: kill unused file kde-locale-5.nix #30132

merged 1 commit into from Oct 30, 2017

Conversation

4z3
Copy link
Contributor

@4z3 4z3 commented Oct 5, 2017

Motivation for this change

kde-locale-5.nix isn't referenced anymore.

There's a related discussion at d7e9248#commitcomment-24737410.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

4z3 referenced this pull request Oct 5, 2017
@ttuegel
kdeApplications: 17.04.0 -> 17.04.1
d7e9248
@orivej orivej merged commit 92dadab into NixOS:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@4z3 @bkchr @orivej @FRidh