Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 1.17.1 -> 1.17.2 #30544

Merged
merged 1 commit into from Oct 18, 2017
Merged

vscode: 1.17.1 -> 1.17.2 #30544

merged 1 commit into from Oct 18, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@NeQuissimus NeQuissimus added 8.has: package (update) 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 18, 2017
@Mic92 Mic92 merged commit 0ce4382 into master Oct 18, 2017
@NeQuissimus NeQuissimus deleted the vscode_1_17_2 branch October 18, 2017 15:58
@Mic92
Copy link
Member

Mic92 commented Oct 18, 2017

also backported in 0990021

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants