Netdata version bump and module permission fix #30550
Conversation
apps.plugin requires capabilities for full process monitoring. Add a setuid and new derivation to include that data as netdata doesn't support using multiple plugin directories yet.
| echo '#!${pkgs.bash}/bin/bash | ||
| exec /run/wrappers/bin/apps.plugin $@ | ||
| ' >$out/libexec/netdata/plugins.d/apps.plugin | ||
| chmod 755 $out/libexec/netdata/plugins.d/apps.plugin |
There was a problem hiding this comment.
using makeWrapper for this would make it a lot nicer
There was a problem hiding this comment.
I'd agree that makeWrapper would be better, but I ran into some issues because /run/wrappers/bin/ doesn't exist when this is evaluated and it fails to build. I think sandboxing would also cause this to fail because it's out side of the store.
This is quickly becoming moot though. netdata/netdata#2900 should be available in the next release and I can add /run/wrappers/bin/ to the plugin directory list and it will do the right thing without all the wrapping.
| type = types.lines; | ||
| default = ""; | ||
| description = "netdata.conf configuration."; | ||
| type = types.nullOr types.str; |
There was a problem hiding this comment.
any reason not to keep using types.lines here?
There was a problem hiding this comment.
Oh, no reason. I didn't realize this got flipped. I'll switch it back.
LnL7
added
8.has: module (update)
|
There will be a fix upstream landing (probably) in the next release that will make most of the workarounds here obsolete. When that's out, I'll open a new PR. |
Motivation for this change
The version bump is minor, but the module changes allows one of the default plugins to properly read data from
/procto report more process stats. I also added a test to verify the setuid capability.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)I'm all ears if there's a better way to pull in a setuid binary. I tried libredirect but it didn't catch
execveand there's no option in netdata itself yet to specify multiple directories for plugins so I could just use /run/wrappers/bin/apps.plugin directly.