Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tensorflow: dont include cudatoolkit unless cudaSupport is used #30548

Closed
wants to merge 1 commit into from
Closed

tensorflow: dont include cudatoolkit unless cudaSupport is used #30548

wants to merge 1 commit into from

Conversation

CarlOlson
Copy link

@CarlOlson CarlOlson commented Oct 18, 2017 •
edited

Motivation for this change

tensorflow support broke on macOS with recent commit

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 19, 2017

cc @abbradar

@FRidh
Copy link
Member

FRidh commented Oct 19, 2017

I suppose this is not applicable anymore after the recent merge.

@FRidh FRidh added 6.topic: python 0.kind: regression Something that worked before working no longer labels Oct 19, 2017
@abbradar
Copy link
Member

abbradar commented Oct 19, 2017 •
edited

Yeah, should be irrelevant now -- if CUDA is not enabled TensorFlow shouldn't reference cudatoolkit. I can't test my merge on Darwin though -- I wait for Hydra to do that for me but appreciate any help.

@FRidh FRidh closed this Oct 19, 2017
@abbradar
Copy link
Member

I've tried to run this:

nix-build -E 'with import <nixpkgs> { system = "x86_64-darwin"; }; python.pkgs.tensorflow.override { cudaSupport = false; }'

and it fails with:

error: Package ‘cudatoolkit-8.0.61’ in /home/abbradar/nixpkgs/pkgs/development/compilers/cudatoolkit/default.nix:125 is not supported on ‘x86_64-darwin’, refusing to evaluate.

But I don't see where does that cudatoolkit evaluation come from. When I run it on x86_64-linux, there is no mention of cudatoolkit in the resulting .drv. Any ideas?

@FRidh
Copy link
Member

FRidh commented Oct 19, 2017

@abbradar it evaluates and installs for me at 5c11622.

@abbradar
Copy link
Member

@FRidh On Darwin?

@FRidh
Copy link
Member

FRidh commented Oct 19, 2017

@abbradar no, on NixOS. But what is downloaded/build is the Darwin version, right? At least the hash is different.

@abbradar
Copy link
Member

@FRidh Ah, you mean system = "x86_64-darwin" thing. Weird then, why does it fail for me?...

@abbradar
Copy link
Member

Ah, it's because of #7541 and me having cudaSupport = true; in config.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CarlOlson @FRidh @abbradar