Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add support for burp client/server services #30553

Closed
wants to merge 1 commit into from

Conversation

unode
Copy link
Member

@unode unode commented Oct 18, 2017

Motivation for this change

BURP is currently available in nixpkgs but provides no services

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The client service has been tested locally with success.
The server service has not been tested yet.

Aspects pending a better solution:

PS: This is my first attempt at writing a nixos module so any additional feedback is welcome.

@unode
Copy link
Member Author

unode commented Oct 20, 2018

Closing in favor of #48762

@unode unode closed this Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants