shmig: init at 2017-07-24 #30554
Merged
shmig: init at 2017-07-24 #30554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
force-pushed
the
init/shmig-2017-07-24
branch
3 times, most recently
from
1160d36
to
ca162fc
Compare
joachifm
reviewed
Oct 25, 2017
| makeFlags = [ "PREFIX=$(out)" ]; | ||
|
|
||
| postPatch = let | ||
| replacePath = cond: replacement: |
There was a problem hiding this comment.
I think this reduces to optionalString cond ''"${replacement}"''
joachifm
reviewed
Oct 25, 2017
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Database migration tool written in BASH. |
There was a problem hiding this comment.
Just a nit but is the implementation language really important information?
There was a problem hiding this comment.
I always use the description from GitHub. However I think that you might be right, I'll fine a better one :-)
There was a problem hiding this comment.
I don't consider it a blocker
Ma27
force-pushed
the
init/shmig-2017-07-24
branch
from
ca162fc
to
02b15a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
shmigis a simple, shell-based database migration tool which is quite helpful.To avoid building several (possibly useless) derivations, I made the usage of MySQL, PgSQL and SQLite optional. These values are empty which causes the following error if you try to use them:
shmig: unknown database type: sqlite.Using an override expression it is possible to enable support for one of these databases.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)