Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eclipse 471a #30547

Closed
wants to merge 2 commits into from
Closed

Eclipse 471a #30547

wants to merge 2 commits into from

Conversation

jerith666
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I've only executed eclipse-platform on x86_64; the others, I just built but did not try to run.

@jerith666 jerith666 requested a review from rycee as a code owner October 18, 2017 16:38
rycee
rycee requested changes Oct 18, 2017
View reviewed changes
Copy link
Member

@rycee rycee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good in general but you also need to change the eclipse package names. For example, name = "eclipse-sdk-4.7"; should be updated to name = "eclipse-sdk-4.7.1a";, the same holds for the platform package.

@jerith666
Copy link
Contributor Author

fixed in 5afb76b -- sorry!

@rycee
Copy link
Member

rycee commented Oct 18, 2017

Rebased to master in 346fa91. Many thanks for the version updates!

@rycee rycee closed this Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee rycee requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerith666 @rycee