Raise Errno::ENOTDIR if the parent of an opened file is not a directory.

Note that Errno::ENOENT is raised on Windows. This is consistent with the MRI implementation.
jruby · Oct 18, 2017 · 870011e · 870011e
1 parent 471b9c9
commit 870011e
Showing 4 changed files with 13 additions and 0 deletions.
diff --git a/core/src/main/java/org/jruby/util/RegularFileResource.java b/core/src/main/java/org/jruby/util/RegularFileResource.java
@@ -173,6 +173,8 @@ public Channel openChannel(ModeFlags flags, int perm) throws ResourceException {
                         throw new ResourceException.TooManySymlinks(absolutePath());
                     case EISDIR:
                         throw new ResourceException.FileIsDirectory(absolutePath());
+                    case ENOTDIR:
+                        throw new ResourceException.FileIsNotDirectory(absolutePath());
                     default:
                         throw new ResourceException.IOError(new IOException("unhandled errno: " + errno));
 

diff --git a/core/src/main/java/org/jruby/util/ResourceException.java b/core/src/main/java/org/jruby/util/ResourceException.java
@@ -32,6 +32,10 @@ public static class FileIsDirectory extends ErrnoException {
         public FileIsDirectory(String path) { super("EISDIR", path); }
     }
 
+    public static class FileIsNotDirectory extends ErrnoException {
+        public FileIsNotDirectory(String path) { super ("ENOTDIR", path); }
+    }
+
     public static class FileExists extends ErrnoException {
         public FileExists(String path) { super("EEXIST", path); }
     }

diff --git a/core/src/main/java/org/jruby/util/io/PosixShim.java b/core/src/main/java/org/jruby/util/io/PosixShim.java
@@ -416,6 +416,8 @@ public Channel open(String cwd, String path, ModeFlags flags, int perm) {
             errno = Errno.EEXIST;
         } catch (ResourceException.FileIsDirectory e) {
             errno = Errno.EISDIR;
+        } catch (ResourceException.FileIsNotDirectory e) {
+            errno = Errno.ENOTDIR;
         } catch (ResourceException.NotFound e) {
             errno = Errno.ENOENT;
         } catch (ResourceException.PermissionDenied e) {

diff --git a/test/jruby/test_io.rb b/test/jruby/test_io.rb
@@ -205,6 +205,11 @@ def test_open_with_block
     assert_raises(Errno::EBADF) { f.close }
   end
 
+  def test_open_child_of_file
+    ensure_files @file
+    assert_raises(WINDOWS ? Errno::ENOENT : Errno::ENOTDIR) { File.open(File.join(@file, 'child')) }
+  end
+
   unless WINDOWS # Windows doesn't take kindly to perm mode tests
     def test_sysopen
       ensure_files @file