stapler: init at 2016-04-24 #30386
Closed
stapler: init at 2016-04-24 #30386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rycee
reviewed
Nov 1, 2017
| buildPythonApplication rec { | ||
| pname = "stapler"; | ||
| version = "2016-04-24"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
Since this is an unreleased version the name should be "${pname}-unstable-${version}".
rycee
reviewed
Nov 1, 2017
| propagatedBuildInputs = [ pypdf2 more-itertools ]; | ||
|
|
||
| checkPhase = '' | ||
| staplelib/tests.py |
There was a problem hiding this comment.
Python is not in PATH here so need to do patchShebangs staplelib/tests.py before running the test script.
There was a problem hiding this comment.
Actually also need to patchShebangs stapler since the test script runs the stapler command. I'd suggest to have something like
patchPhase = ''
patchShebangs staplelib/tests.py
patchShebangs stapler
'';
checkPhase = "staplelib/tests.py";
|
Closing until I have time to work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I use
fetchFromGitHubinstead offetchPypibecause the files needed to run the tests were not uploaded to PyPI.Also, it doens't make sense to use the commit for a specific version, since I don't think a new version will ever be published.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)