Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli-visualizer: fix #30388

Merged
merged 1 commit into from Oct 16, 2017
Merged

cli-visualizer: fix #30388

merged 1 commit into from Oct 16, 2017

Conversation

infinisil
Copy link
Member

Motivation for this change

cli-visualizer hasn't been working (at least for me with pulseaudio backend) since #28334. Downgrading to ncurses5 at least made it work somehow. There are still some weird artifacts though, with konsole, alacritty and maybe others, but not termite and probably xterm. The issue is the same as dpayne/cli-visualizer#62. Wrapping the binary with TERM set to either xterm-termite or rxvt-256color solves the issue for now (the latter of which I used here). See this comment.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 13, 2017

does this also needs to be fixed in 17.09?

@infinisil
Copy link
Member Author

Yes, it doesn't work in 17.09 either. Just tested cherry-picking this on release-17.09, works just fine.

@Mic92 Mic92 merged commit 09deacb into NixOS:master Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants