-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
biome changes are not applied unless biomemap is parsed #236
Comments
This has been supported as of 1.3.0-5 |
Then I'm missing something in this config. Here's a re-homed KSC on Duna:
Note that I have a 'short name' without spaces and a displayName (and displayname) with spaces. I want the name with spaces to display. And here's a science report and KerbNet image: The more complete example is here. What am I missing to make biome names display correctly in KerbNet? And while I'm at it, I'm also missing something with gender because the crew report reads, "from MidlandSea of a Duna," instead of, "from Duna's MidlandSea." Maybe if Kittopia-tech was updated for KSP 1.3.0 we could get fresh dumps and working examples. |
Are you sure kerbnet can display the displayname ? |
When I go to an unmodified stock world with Kopernicus running, such as Ike in this configuration, biome names show up in KerbNet. |
no idea, as far as I can tell the name is set correctly |
the issue here is that the changes to the biomes are only applied if the biomeMap field is parsed
(I suppose) you didn't post all your configs so that's my best guess |
smh apparently I'll change that and submit a PR later |
this should be solved with #238 |
I just posted a short example. The full example is in the link that followed, and here's another link to it. I'll take a look at a test build based on #238 if you'd like, after six hours from now when I'm off work. |
this issue has been solved, it will be included in the next release |
Biome names for non-stock worlds were not appearing in KerbNet's biome views as of 1.3.0-6. Is this, along with localization, supported in 1.3.0-7 now, and are there example configurations to look at?
The text was updated successfully, but these errors were encountered: