Displayname #238
Merged
Displayname #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StollD
reviewed
Sep 28, 2017
| { | ||
| get { return attribute.displayname; } // This is not displayName because of reasons | ||
| set { attribute.displayname = value; } | ||
| get { return Localizer.Format(attribute.localizationTag); } // This is not displayName because of reasons |
There was a problem hiding this comment.
Could we just return the value without passing it to Localizer.Format?
StollD
reviewed
Sep 28, 2017
| @@ -338,6 +337,10 @@ void IParserEventSubscriber.Apply(ConfigNode node) | |||
| // PostApply Event | |||
| void IParserEventSubscriber.PostApply(ConfigNode node) | |||
| { | |||
| // Replace biomes | |||
| if (biomes?.Count() > 0) | |||
| celestialBody.BiomeMap.Attributes = biomes.Select(b => b.attribute).ToArray(); | |||
There was a problem hiding this comment.
Can you add a check if the biome map is null, and if yes, throw an appropriate exception?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.