Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biome changes are not applied unless biomemap is parsed #236

Closed
gordonfpanam opened this issue Sep 25, 2017 · 10 comments
Closed

biome changes are not applied unless biomemap is parsed #236

gordonfpanam opened this issue Sep 25, 2017 · 10 comments

Comments

@gordonfpanam
Copy link

gordonfpanam commented Sep 25, 2017

Biome names for non-stock worlds were not appearing in KerbNet's biome views as of 1.3.0-6. Is this, along with localization, supported in 1.3.0-7 now, and are there example configurations to look at?

@gordonfpanam gordonfpanam changed the title displayName (or displayname) for biomes supported yet? displayName (or displayname) for biome localization supported yet? Sep 25, 2017
@StollD
Copy link
Member

StollD commented Sep 25, 2017

This has been supported as of 1.3.0-5

@gordonfpanam
Copy link
Author

gordonfpanam commented Sep 26, 2017

Then I'm missing something in this config. Here's a re-homed KSC on Duna:

Body
{
	name = Kerbin
	cbNameLater = Duna
	cacheFile = AlienSpacePrograms/0Miscellany/Cache/Dunakerbin.bin
	Template
	{
		name = Kerbin
		removePQSMods = PQSLandControl,QuadEnhanceCoast,VertexHeightMap,VertexHeightNoiseVertHeightCurve2,VertexRidgedAltitudeCurve,VertexSimplexHeightAbsolute
		removeOcean = True
	}
	Debug
	{
		update = true
	}
	Properties
	{
		displayName = Duna
		displayname = Duna
		Biomes
		{
			Biome
			{
				name = MidlandSea
				displayname = Midland Sea
				displayName = Midland Sea
				value = 0
				color = 1,0.568627477,0.00784313772,1
			}
		}
	}
}

Note that I have a 'short name' without spaces and a displayName (and displayname) with spaces. I want the name with spaces to display.

And here's a science report and KerbNet image:
screenshot2

The more complete example is here.

What am I missing to make biome names display correctly in KerbNet? And while I'm at it, I'm also missing something with gender because the crew report reads, "from MidlandSea of a Duna," instead of, "from Duna's MidlandSea."

Maybe if Kittopia-tech was updated for KSP 1.3.0 we could get fresh dumps and working examples.

@Sigma88
Copy link
Contributor

Sigma88 commented Sep 26, 2017

Are you sure kerbnet can display the displayname ?

@gordonfpanam
Copy link
Author

When I go to an unmodified stock world with Kopernicus running, such as Ike in this configuration, biome names show up in KerbNet.

@Sigma88
Copy link
Contributor

Sigma88 commented Sep 26, 2017

no idea, as far as I can tell the name is set correctly

@Sigma88 Sigma88 changed the title displayName (or displayname) for biome localization supported yet? biome changes are not applied unless biomemap is parsed Sep 28, 2017
@Sigma88
Copy link
Contributor

Sigma88 commented Sep 28, 2017

the issue here is that the changes to the biomes are only applied if the biomeMap field is parsed

celestialBody.BiomeMap.Attributes = biomes.Select(b => b.attribute).ToArray();

(I suppose)

you didn't post all your configs so that's my best guess

@Sigma88
Copy link
Contributor

Sigma88 commented Sep 28, 2017

smh

apparently displayname is set from localizationTag

I'll change that and submit a PR later

@Sigma88
Copy link
Contributor

Sigma88 commented Sep 28, 2017

this should be solved with #238

@gordonfpanam
Copy link
Author

gordonfpanam commented Sep 28, 2017

the issue here is that the changes to the biomes are only applied if the biomeMap field is parsed

I just posted a short example. The full example is in the link that followed, and here's another link to it.

I'll take a look at a test build based on #238 if you'd like, after six hours from now when I'm off work.

@Sigma88
Copy link
Contributor

Sigma88 commented Sep 28, 2017

this issue has been solved, it will be included in the next release

@StollD StollD closed this as completed Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants