robo3t: added 1.1.1 #29903
Merged
robo3t: added 1.1.1 #29903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 28, 2017
pkgs/top-level/all-packages.nix
Outdated
| @@ -19040,6 +19040,8 @@ with pkgs; | |||
|
|
|||
| redis-desktop-manager = libsForQt56.callPackage ../applications/misc/redis-desktop-manager { }; | |||
|
|
|||
| robo3t = callPackage ../applications/misc/robo3t { }; | |||
|
|
|||
| robomongo = callPackage ../applications/misc/robomongo { }; | |||
There was a problem hiding this comment.
Is there a need for the old version?
There was a problem hiding this comment.
I am new to nixos so I don't know if there is a way to mark an attribute as deprecated. Should the old version be left there to avoid breaking people's configs that use it? Or is it standard practice to just remove something like that?
There was a problem hiding this comment.
Just remove the old package/attribute and add an alias to pkgs/top-level/aliases.nix to point to the new name.
There was a problem hiding this comment.
OK thanks, amended commit.
|
Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this is a newer version of "robomongo". The project changed its name.