Skip to content

Commit

Permalink
cura: build with Qt 5.6
Browse files Browse the repository at this point in the history 
Workaround Ultimaker/Cura#2596
  • Loading branch information
@abbradar
abbradar committed Oct 22, 2017
1 parent e458c44 commit 1b2cc71
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkgs/top-level/all-packages.nix
View file
Expand Up @@ -16522,7 +16522,7 @@ with pkgs;
curaengine = callPackage ../applications/misc/curaengine {
inherit (python3.pkgs) libarcus;
};
cura = qt5.callPackage ../applications/misc/cura { };
cura = qt56.callPackage ../applications/misc/cura { };

curaLulzbot = callPackage ../applications/misc/cura/lulzbot.nix { };

Expand Down
9 changes: 8 additions & 1 deletion pkgs/top-level/python-packages.nix
View file
Expand Up @@ -256,6 +256,10 @@ in {
pythonPackages = self;
};

pyqt56 = pkgs.libsForQt56.callPackage ../development/python-modules/pyqt/5.x.nix {
pythonPackages = self;
};

pyqt5 = pkgs.libsForQt5.callPackage ../development/python-modules/pyqt/5.x.nix {
pythonPackages = self;
};
Expand Down Expand Up @@ -26536,7 +26540,10 @@ EOF

twilio = callPackage ../development/python-modules/twilio { };

uranium = callPackage ../development/python-modules/uranium { };
uranium = callPackage ../development/python-modules/uranium {
# https://github.com/Ultimaker/Cura/issues/2596
pyqt5 = self.pyqt56;
};

vine = callPackage ../development/python-modules/vine { };

Expand Down

3 comments on commit 1b2cc71

@Ghostkeeper
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cura currently requires Qt 5.8. See our environment builder: https://github.com/Ultimaker/cura-build-environment/blob/403ff911344a31cc13086ee10f648d49172a5c1b/projects/qt.cmake#L1

@abbradar
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ghostkeeper We sadly don't have Qt 5.8 (only 5.6 and 5.9) but fun thing is that it's seemingly working for me. I guess we'll leave it this way and hopefully patch for Ultimaker/Cura#2596 comes soon so we can move to 5.9. However just in case, any idea what features are broken to estimate the problem?

@Ghostkeeper
Copy link

@Ghostkeeper Ghostkeeper commented on 1b2cc71 Oct 22, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I recall, making a setting visible that shows a selection of extruders. To reproduce:

  • Add a multi-extrusion printer, such as Ultimaker 3.
  • Go into Custom settings and click the gear at the Infill category.
  • Click the checkbox before the "Infill Extruder" setting to make it visible.

Result: The application crashes (with a segfault?).

If it doesn't occur, all the better of course. If it does occur again, it is less of a bug than the main window not appearing at all so 5.6 would be better than 5.9.2. So if 5.8 is no option, I think you'll have to stick with 5.6 then until that bug is resolved.

Edit: I looked into our history and found that we upgraded from 5.5 to 5.7 to fix a deadlocking problem, but that deadlock was also fixed in 5.6 (it's just that 5.7 was already out at the time so we just upgraded to the most modern version). Then we upgraded to 5.8 for the reasons mentioned above.

The first Cura version that had the extruder selections that caused the bug was version 2.7, so providing Nix with Cura 2.6 would also prevent the bug (but have less features).

Please sign in to comment.