Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.{ssreflect,mathcomp}: 1.6.1 -> 1.6.2 #30690

Closed
wants to merge 2 commits into from
Closed

coqPackages.{ssreflect,mathcomp}: 1.6.1 -> 1.6.2 #30690

wants to merge 2 commits into from

Conversation

maximedenes
Copy link
Contributor

Motivation for this change
Things done
  • [ X ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ X ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ X ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [ X ] Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Oct 22, 2017

This breaks mathcomp for Coq 8.4:

nix-build-coq8.4-mathcomp-1.6.2.drv-0/math-comp-mathcomp-1.6.2/mathcomp/ssreflect/eqtype.v", line 3, characters 0-44:
Error: Cannot find library mathcomp.ssreflect.ssreflect in loadpath
make[1]: *** [Makefile.coq:404: ssreflect/eqtype.vo] Error 1

@maximedenes maximedenes mentioned this pull request Oct 23, 2017
Merged
@maximedenes
Copy link
Contributor Author

Indeed, this is an upstream regression. I reported it, a new release is going to happen in the coming days. I'll update this PR once it is available. Better not merge it until then.

@Zimmi48
Copy link
Member

Zimmi48 commented Nov 7, 2017

Math-Comp 1.6.4 has been released now.

@maximedenes
Copy link
Contributor Author

Math-Comp 1.6.4 has been released now.

I don't think it's been announced yet, but maybe I missed it.

@Zimmi48
Copy link
Member

Zimmi48 commented Nov 7, 2017

I don't think it's been announced yet, but maybe I missed it.

I don't follow the proper list to see the announcement, I think but coq/opam#220 has been merged. If it is in OPAM, I don't see why it shouldn't be in nixpkgs.

@maximedenes
Copy link
Contributor Author

Indeed, I don't know why they didn't announce the release. Will update this today.

@maximedenes
Copy link
Contributor Author

Superseded by #31354

@maximedenes maximedenes closed this Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maximedenes @vbgl @Zimmi48