kitty: init at 0.4.2 #30687
Merged
kitty: init at 0.4.2 #30687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Oct 25, 2017
| cp -r share/* $out/share/ | ||
| cp -r lib/* $out/lib/ | ||
|
|
||
| wrapProgram "$out/bin/kitty" --set PATH "$out/bin:/run/wrappers/bin:/run/current-system/sw/bin:${stdenv.lib.makeBinPath [ imagemagick ]}" |
There was a problem hiding this comment.
Because I did not know about --prefix :-) This is my first recipe besides just minor version updates.
Mic92
reviewed
Oct 25, 2017
| sha256 = "1gvr9l3bgbf87b2ih36zfi5qcga925vjjr8snbak7sgxqzifimij"; | ||
| }; | ||
|
|
||
| buildInputs = [ pkgconfig glew fontconfig glfw ncurses libunistring ]; |
There was a problem hiding this comment.
pkgconfig goes to nativeBuildInputs.
Mic92
changed the title
Mic92
reviewed
Oct 25, 2017
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/kovidgoyal/kitty; | ||
| description = "A modern, hackable, featureful, OpenGL based terminal emulator"; | ||
| license = licenses.gpl3; |
There was a problem hiding this comment.
Do you want to maintain this package?
There was a problem hiding this comment.
Well, I suppose yes. But I do not insist on that ;-)
There was a problem hiding this comment.
Okay, then please add yourself to lib/maintainers.nix as well as to this package in meta.maintainers. Further information can be found here: https://nixos.wiki/wiki/Get_Involved#Becoming_a_Nixpkgs_maintainer
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/kovidgoyal/kitty.git
Motivation for this change
Adding new application: terminal kitty (opengl, c, python)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)