Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pam: add optional pam_gnome_keyring integration #30686

Merged
merged 1 commit into from Jan 2, 2018
Merged

pam: add optional pam_gnome_keyring integration #30686

merged 1 commit into from Jan 2, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 22, 2017

Motivation for this change

Add Gnome Keyring auto-unlock in addition to similar KWallet option. GDM does this, but other applications not. For example by setting security.pam.services.slim.enableGnomeKeyring = true; there will be an option in Gnome Keyring password asking dialog to remember the password when using default SLIM login manager.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

Ref. #21859, #17044, #21860, #20608, #20608

bjornfor
bjornfor approved these changes Oct 22, 2017
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. (Did not test.)

@ghost
Copy link
Author

ghost commented Jan 1, 2018

cc @Mic92

@Mic92 Mic92 merged commit 310ad43 into NixOS:master Jan 2, 2018
@ghost
Copy link
Author

ghost commented Jan 2, 2018

@Mic92 Thank you much!

@ghost ghost deleted the keyring branch January 2, 2018 14:33
@jtojnar jtojnar mentioned this pull request Mar 4, 2018
Closed
8 tasks
@worldofpeace worldofpeace mentioned this pull request Jan 19, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjornfor @Mic92 @GrahamcOfBorg