Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/services.nginx: Fix globalRedirect example #30674

Merged
merged 1 commit into from Oct 22, 2017
Merged

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Oct 22, 2017

Virtual host globalRedirect attribute accepts a hostname not a URL

return 301 http${optionalString ssl "s"}://${vhost.globalRedirect}$request_uri;

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@globin globin merged commit 3c48a1e into NixOS:master Oct 22, 2017
@jtojnar jtojnar deleted the patch-1 branch November 18, 2017 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants