Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pandas: fix evaluation #30679

Closed
wants to merge 1 commit into from
Closed

pythonPackages.pandas: fix evaluation #30679

wants to merge 1 commit into from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 22, 2017 •
edited

Motivation for this change

It seems as running the pythonPackages.pandas testsuite fails on NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Oct 22, 2017

We won't just disable the whole test suite. Acceptable solutions are:

  • fixing the test suite. Likely upstream has done so.
  • disabling the specific tests.

@FRidh FRidh closed this Oct 22, 2017
@Ma27 Ma27 deleted the fix-python-packages-pandas-eval branch October 22, 2017 10:23
@Ma27
Copy link
Member Author

Ma27 commented Oct 22, 2017

fair point. Will have a deeper look at the test suite in the next time :-)

@teto
Copy link
Member

teto commented Oct 30, 2017

see #30956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @FRidh @teto