alembic: use threadsafe hdf5 #30682
Merged
alembic: use threadsafe hdf5 #30682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the issue about |
guibou
force-pushed
the
guibou_alembic_hdf5
branch
2 times, most recently
from
d72b991
to
0b59ffd
Compare
guibou
changed the title
peterhoeg
reviewed
Oct 25, 2017
pkgs/top-level/all-packages.nix
Outdated
| alembic = callPackage ../development/libraries/alembic {}; | ||
| alembic = callPackage ../development/libraries/alembic { | ||
| hdf5 = hdf5-threadsafe; | ||
| }; |
There was a problem hiding this comment.
Since hdf5-threadsafe is in all-packages.nix why not just pass that in directly instead of overriding hdf5? This makes things more explicit for alembic and easier to understand.
There was a problem hiding this comment.
You mean to directly use hdf5-threadsafe inside alembic? Yes, that's a solution. I'll update the PR with this.
guibou
force-pushed
the
guibou_alembic_hdf5
branch
from
0b59ffd
to
04df8c6
Compare
|
Any update? I'm using this (2 lines) changes in production since October without any issue, can we merge? |
guibou
changed the title
peterhoeg
reviewed
Jan 16, 2018
| @@ -14,7 +14,7 @@ stdenv.mkDerivation rec | |||
|
|
|||
| outputs = [ "bin" "dev" "out" "lib" ]; | |||
|
|
|||
| buildInputs = [ unzip cmake openexr hdf5 ]; | |||
| buildInputs = [ unzip cmake openexr hdf5-threadsafe ]; | |||
There was a problem hiding this comment.
Please shift unzip and cmake to nativeBuildInputs.
Compiled with thread safe support and without the High Level library which is incompatible with thread safety.
guibou
force-pushed
the
guibou_alembic_hdf5
branch
from
04df8c6
to
2e4c22b
Compare
|
Thanks @guibou ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allowing
alembic(and perhaps other libraries) to loadhdf5encoded files in a concurrent manner. To achieve this, this change:hdf5in a separate packagehdf5-threadsafe.alembicpackageDiscussion
By default,
hdf5is not thread-safe hence--enable-threadsafeis mandatory to loadalembicfile (usinghdf5) in a concurrent context.However this change is not benign for all
hdf5users: the High Level (hl) library included inhdf5does not officially support thread safety. The recommended way is to--disable-hl. However this may not be acceptable for some users of hdf5 (actually 21 derivation in nixpkgs). So I do not propose this for the default hdf5 derivation.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)