Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrb: init at 0.5.1 #30688

Merged
merged 1 commit into from Nov 5, 2017
Merged

vrb: init at 0.5.1 #30688

merged 1 commit into from Nov 5, 2017

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Oct 22, 2017

Motivation for this change

This adds vrb 0.5.1: a virtual ring buffer library for C.

This is based on a PKGBUILD for ArchLinux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

version = "0.5.1";

src = fetchurl {
url = "http://vrb.sourceforge.net/download/${name}.tar.bz2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use mirror://sourceforge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VRB doesn't host files under https://sourceforge.net/projects/vrb/files/, but only through its sourceforge-hosted website (http://vrb.sourceforge.net/). I couldn't find a way to get these files using a mirror like http://downloads.sourceforge.net/, so I presume it is not possible to use mirror://sourceforge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, thank you.

@orivej orivej merged commit 585e9cc into NixOS:master Nov 5, 2017
@bobvanderlinden bobvanderlinden deleted the pr-vrb-init branch November 5, 2017 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants