Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/gitlab: fix startup script #30684

Merged
merged 1 commit into from Oct 22, 2017
Merged

nixos/gitlab: fix startup script #30684

merged 1 commit into from Oct 22, 2017

Conversation

brainrake
Copy link
Contributor

@brainrake brainrake commented Oct 22, 2017

Motivation for this change

The preStart script used a hardcoded "git" user instead of the cfg value.
The service failed to start, in particular with the default value for services.gitlab.user, "gitlab".

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The preStart script used a hardcoded "git" user instead of the cfg value.
@globin globin merged commit a89b28f into NixOS:master Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants