Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/libreswan: add missing runtime dependencies #30678

Merged
merged 1 commit into from Oct 22, 2017
Merged

nixos/libreswan: add missing runtime dependencies #30678

merged 1 commit into from Oct 22, 2017

Conversation

jpotier
Copy link
Contributor

@jpotier jpotier commented Oct 22, 2017

Motivation for this change

Module was not usable (service failed to start due to missing paths).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jpotier
Copy link
Contributor Author

jpotier commented Oct 22, 2017

@afranchuk and @zimbatm you have made modifications to this module, any thoughts?

@jpotier jpotier mentioned this pull request Oct 22, 2017
Closed
@globin globin merged commit ff56245 into NixOS:master Oct 22, 2017
@jpotier jpotier deleted the upgrade-nix-module-libreswan branch October 22, 2017 16:15
@afranchuk
Copy link
Contributor

The change should be fine. I'm guessing those are new run-time dependencies? It certainly worked with older versions.

@jpotier
Copy link
Contributor Author

jpotier commented Oct 22, 2017 •
edited

I just needed the module, and in the logs it complained. I basically added everything that was missing so that the service successfully starts. One thing I haven't added is the loading of the af_key kernel module, apparently required for netkey. It should have been autoloaded, but there's no note in the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpotier @afranchuk @globin @MartinPotier