nixos/xl2tpd: add the xl2tpOptions #30677
Conversation
This option allows the user to give a full configuration file, and bypass the — sometimes problematic — default configuration.
|
@obadz you are the original writter of the module, any thoughts? |
|
@abbradar you are the maintainer of the underlying |
|
@jpotier, is there really no way for you to add the options you care about to the module rather than provide a string-based fallback? |
|
Hmm, sure, there should be a way. This will require much more work though. I'll try and come up with something more detailed, and keeping your options. I proposed this, because I've seen it implemented in other modules this way. In any case, I'll have to eliminate some of the defaults. |
|
Is this related to your E-mail where you try to set this up as a client rather than server? |
|
yep, it is. |
|
Do you want to try the networkmanager module for client side instead? |
|
Well, I don't use networkmanager and installing it will just change too
much of my usual settings (I mean, how much of networkmanager's config
can be declared in a .nix file?)
Le 23/10/17 à 11:43, obadz a écrit:
… Do you want to try the networkmanager module for client side instead?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#30677 (comment)
|
|
Yes networkmanager lives outside of nix. If you want to avoid that you'll need to do this from a module indeed. This module was meant to configure the server side. Not sure whether client version should be another module or same module with different options. My first guess would be separate module but feel free to propose what you feel is best. |
|
So either it's a client module that lives in
services.xl2tpd-client
Or the current module is split (like openvpn) between
services.xl2tpd.client and
services.xl2tpd.server
I think there are reusable config options between the server and the client,
so it may seem to be a better idea to have that under a single module.
Le 23/10/17 à 12:06, obadz a écrit:
… Yes networkmanager lives outside of nix. If you want to avoid that you'll need to do this from a module indeed.
This module was meant to configure the server side. Not sure whether client version should be another module or same module with different options. My first guess would be separate module but feel free to propose what you feel is best.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#30677 (comment)
|
|
Well, now that I thought about it a little bit more, I don't get why we should separate client and server. I'll just enable more options, but people can choose by setting the options. A good next point on the roadmap would be to start several instances of the service. |
|
Status of this? |
|
Let's close this one. I'll PR something else when I get the time. |
This option allows the user to give a full configuration file, and
bypass the — sometimes problematic — default configuration.
Motivation for this change
The module is not usable as-is with my company's setup. I suspect this will be the case for other people, so the simplest option is to give users the choice to provide a full config file.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)