modemmanager: rename ModemManager.service to modem-manager.service #30452
Conversation
This is in line with NetworkManager.service being renamed to network-manager.service
|
this currently fails due to ltk build process being broken, see #30462 |
| @@ -30,7 +31,8 @@ stdenv.mkDerivation rec { | |||
| ''; | |||
|
|
|||
| postInstall = '' | |||
| mv $out/$out/etc/systemd/system/ModemManager.service $out/etc/systemd/system | |||
| # rename to modem-manager to be in style | |||
| mv $out/$out/etc/systemd/system/ModemManager.service $out/etc/systemd/system/modem-manager.service | |||
There was a problem hiding this comment.
I think we should stick to upstream here. Consistency is not worth breaking upstream documentation and expectation how things are named.
There was a problem hiding this comment.
Granted. I just found it weird renaming was done for NetworkManager, but not here. Should this also be reverted for NetworkManager then?
There was a problem hiding this comment.
Mhm. I would have not done it there too for the same reason.
There was a problem hiding this comment.
So it seems I have a different opinion then @domenkozar in 2014.
There was a problem hiding this comment.
I'd say as long as NetworkManager is renamed to modem-manager, ModemManager should be called modem-manager, too.
The current state is more than confusing.
|
@domenkozar What do we do with this? |
|
Naming is hard, I don't have an opinion anymore about this. There is no win-win outcome :) |
…
This is in line with NetworkManager.service being renamed to
network-manager.service
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)