sudo and sssd: Enable sssd support in sudo and building of sudo library in sssd #30445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lejonet
changed the title
|
Is that last commit a fixup of the first commit? |
|
Yes, it is |
|
Then please squash them. (Easier to review etc.) |
|
Will do |
…se to fetch sudoers rules from SSSD
|
Now they are rebased, man my git "muscles" are out of shape :P |
bjornfor
approved these changes
Oct 15, 2017
bjornfor
approved these changes
Oct 16, 2017
|
Applied to master (eafcfaf and parent). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Sudo has support to poll SSSD for its sudoers rules, but it has to be compiled into sudo and it requires a sudo plugin, libsss_sudo.so, from SSSD to function.
Added optional arguments to sudo and sssd to enable this functionality and have tested it, via packageOverrides, on a baremetal nixos machine. Both sssd and sudo was built with nix.useSandbox = true and I tried the functionality it brings and it works, I have sudoers rules in an openldap directory which I could apply after appending sudoers: files sss to nsswitch.conf.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)