Add Pipenv, update pew #30442
Add Pipenv, update pew #30442
Conversation
Pew was actually broken, due to a SHELL PATH check that had been added in the previous release (though this shouldn't have hampered users with bash as their shell)
pkgs/top-level/python-packages.nix
Outdated
| @@ -15567,6 +15578,27 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| pipenv = buildPythonPackage rec { | |||
There was a problem hiding this comment.
Please move this expression to python-modules as described in the header of this file.
There was a problem hiding this comment.
@Mic92 this is not a library, but a cli tool. The header says to keep cli tools in this file
There was a problem hiding this comment.
It says:
Python packages that do not need to be available for each interpreter version do not belong in this packages set.
which means not in python-packages.nix at all.
For example gpodder is a podcast client written in python and we put it not into python-packages.nix since we only need one version of it build against one python version.
Looking at the documentation https://github.com/kennethreitz/pipenv#basic-concepts it seems we also only need one version of pipenv for both python2/python3. In that case please add it to top-level/all-packages.nix
There was a problem hiding this comment.
Uhm, I think that the text in the header should be updated then, since it says
Expressions for Python libraries are supposed to be in
pkgs/development/python-modules/<name>/default.nix.
If libraries aren't supposed to be in python-packages.nix at all, that leaves only cli application...
I presume that if neither cli applications nor libraries are supposed to live in python-packages.nix, then this file still exists only for legacy reasons?
There was a problem hiding this comment.
We still add python libraries there, but are using callPackage, where the expression is written to
python-modules, i.e: email_validator = callPackage ../development/python-modules/email-validator { };
pkgs/top-level/python-packages.nix
Outdated
| pipenv = buildPythonPackage rec { | ||
| name = "pipenv-8.2.7"; | ||
|
|
||
| src = pkgs.fetchurl { |
There was a problem hiding this comment.
we have a fetchPypi function for that.
pkgs/top-level/python-packages.nix
Outdated
| meta = { | ||
| description = "Python Development Workflow for Humans"; | ||
| license = licenses.mit; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
Do you want to maintain this package?
There was a problem hiding this comment.
Ok, I added myself as maintainer
|
@Mic92 I moved the apps out to their own files, and applied the other changes |
|
Thank you
Sent from mobile. Please excuse my brevity.
…On 16 Oct 2017 9:01 am, "Jörg Thalheim" ***@***.***> wrote:
Closed #30442 <#30442> via e55b99e
<e55b99e>
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#30442 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAt8wwMjGmytojvrydbXwxiutD5vI1Uyks5ssw1VgaJpZM4P5zYf>
.
|
Motivation for this change
Add pipenv, bump pew (it's a dependency, and it was broken)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)