Raise Errno::EISDIR when opening a directory for reading on Windows #4818

philr · 2017-10-15T15:05:30Z

On Windows, MRI 2.0.0 and later raises Errno::EISDIR when attempting to open a directory for reading:

> File.open('C:\\Windows', 'r')
Errno::EISDIR: Is a directory @ rb_sysopen - C:\Windows
        from (irb):1:in `initialize'
        from (irb):1:in `open'
        from (irb):1

However, JRuby 9.1.13.0 raises Errno::EACCES instead:

> File.open('C:\\Windows', 'r')
Errno::EACCES: Permission denied - C:\Windows
        from org/jruby/RubyFile.java:366:in `initialize'
        from org/jruby/RubyIO.java:1154:in `open'
        from (irb):1:in `<eval>'
        from org/jruby/RubyKernel.java:994:in `eval'
        from org/jruby/RubyKernel.java:1292:in `loop'
        from org/jruby/RubyKernel.java:1114:in `catch'
        from org/jruby/RubyKernel.java:1114:in `catch'

This pull request modifies RegularFileResource.openChannel() to throw ResourceException.FileIsDirectory in all cases when opening a directory instead of just for writes.

enebo · 2018-01-10T15:00:45Z

core/src/main/java/org/jruby/util/RegularFileResource.java

@@ -218,7 +218,7 @@ public Channel openChannel(ModeFlags flags, int perm) throws ResourceException {
            return channel;
        }

-        if (file.isDirectory() && flags.isWritable()) {
+        if (file.isDirectory()) {


@philr Should this happen on all platforms and not just windows? Sorry this PR got lost in the cracks.

@enebo On platforms other than Windows (with both MRI and JRuby), File.open(directory) succeeds and an Errno::EISDIR exception is raised when calling File#read.

On Windows, File.open(directory) raises an exception. MRI raises Errno::EISDIR, but JRuby raises Errno::EACCES.

To replicate the behaviour of MRI, it is just this code that handles Windows in the openChannel() method that needs to be changed.

Raise Errno::EISDIR when opening a directory for reading on Windows.

c483cf1

kares added core windows labels Oct 29, 2017

enebo reviewed Jan 10, 2018

View reviewed changes

enebo added this to the JRuby 9.1.16.0 milestone Jan 16, 2018

Merge branch 'master' into file_open_read_raise_eisdir_on_windows

74b1970

enebo merged commit 73846e9 into jruby:master Jan 24, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

Raise Errno::EISDIR when opening a directory for reading on Windows #4818

Raise Errno::EISDIR when opening a directory for reading on Windows #4818

philr commented Oct 15, 2017 •

edited

Loading

enebo Jan 10, 2018

philr Jan 10, 2018

Raise Errno::EISDIR when opening a directory for reading on Windows #4818

Raise Errno::EISDIR when opening a directory for reading on Windows #4818

Conversation

philr commented Oct 15, 2017 • edited Loading

enebo Jan 10, 2018

Choose a reason for hiding this comment

philr Jan 10, 2018

Choose a reason for hiding this comment

philr commented Oct 15, 2017 •

edited

Loading