Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plv8 + build against V8 6.x #30435

Merged
merged 2 commits into from Oct 15, 2017
Merged

Update plv8 + build against V8 6.x #30435

merged 2 commits into from Oct 15, 2017

Conversation

stesie
Copy link
Member

@stesie stesie commented Oct 15, 2017 •
edited

Motivation for this change

With #29726 I started to work on bringing V8 6.x to NixOS, by initially adding it next to v8 package and now migrating stuff from v8 towards v8_6_x gradually.

This pull request updates plv8 to 2.1.0 release and switches to V8 6.x

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@stesie stesie changed the title Update plv8 Update plv8 + build against V8 6.x Oct 15, 2017
@Mic92 Mic92 merged commit 04c6047 into NixOS:master Oct 15, 2017
@Mic92
Copy link
Member

Mic92 commented Oct 15, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stesie @Mic92