Don't try to craft a non-existent item

minetest · Oct 16, 2017 · 422e502 · 422e502
1 parent 75320e7
commit 422e502
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/craftdef.cpp b/src/craftdef.cpp
@@ -907,8 +907,18 @@ class CCraftDefManager: public IWritableCraftDefManager
 					<< " against " << def->dump() << std::endl;*/
 
 				if (def->check(input, gamedef)) {
+					// Check if the crafted node/item exists
+					CraftOutput out = def->getOutput(input, gamedef);
+					ItemStack is;
+					is.deSerialize(out.item, gamedef->idef());
+					if (!is.isKnown(gamedef->idef())) {
+						errorstream << "trying to craft nonexistant " << out.item << ", ignoring recipe" << std::endl;
+						continue;
+					}
+
 					// Get output, then decrement input (if requested)
-					output = def->getOutput(input, gamedef);
+					output = out;
+
 					if (decrementInput)
 						def->decrementInput(input, output_replacement, gamedef);
 					/*errorstream << "Check RETURNS TRUE" << std::endl;*/