Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add science cores to some Bluedog probe cores #779

Closed

Conversation

ts826848
Copy link
Contributor

There were some other cores that didn't have science cores nor something saying how much vessel mass the avionics support. I wasn't sure whether these should have avionics added:

  • Ranger Block 1 Core (bluedog_rangerCore)
  • Galileo Atmospheric Probe (galileo_aprobe)
  • Alouette Core (SXTAlouetteI)
  • Surveyor Core (ca.landv.core)
  • Mariner 1/2 Probe (rn_mariner1_2)
  • Tons of others

@NathanKell
Copy link
Member

Ranger, Surveyor, Mariner should definitely have avionics, the stock/SXT versions of them do have avionics....

@ts826848
Copy link
Contributor Author

Just wondering, would it be better to automatically add science cores to anything that wouldn't have control through other means? For example, I have this in my Avionics.cfg in place of the list of parts that are currently there:

+@PART[*]:HAS[@MODULE[ModuleCommand]:HAS[~minimumCrew[>0]],!MODULE[ModuleAvionics],!MODULE[ModuleProceduralAvionics],!MODULE[ModuleScienceCore]]:FOR[RP-0]
{
    MODULE
    {
        name = ModuleScienceCore
    }
}

So basically anything that doesn't have crew or avionics gets a science core by default. That way, we don't have to list things that require science cores manually.

@NathanKell
Copy link
Member

I think that makes sense, yeah!

@ts826848
Copy link
Contributor Author

Alright, I'll close this PR in favor of one for adding science cores to things without avionics/crew, and one for adding avionics to the Ranger/Surveyor/Mariner cores I listed

@ts826848 ts826848 closed this Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants