bgpdump: init at 2017-09-29 #30461
Merged
bgpdump: init at 2017-09-29 #30461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyp
reviewed
Oct 16, 2017
| meta = { | ||
| homepage = https://bitbucket.org/ripencc/bgpdump/wiki/Home; | ||
| description = ''Analyze dump files produced by Zebra/Quagga or MRT''; | ||
| license = stdenv.lib.licenses.free; |
There was a problem hiding this comment.
I think we can put license = stdenv.lib.licenses.hpnd for this, the license looks largely the same and is only missing two small sentences at the end of the first paragraph about warranty and suitability, which is what the second paragraph is about anyway.
vyp
reviewed
Oct 16, 2017
| { stdenv, fetchzip, autoconf, zlib, bzip2 }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "bgpdump-94a0e724b335"; |
There was a problem hiding this comment.
The version should be in date format, so 2017-09-29. In nix, the version number has to start with a digit, and commit hashes can start with letters, so using a date that points to when the commit happened is preferred to using the commit hash itself for 'unstable' versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)