Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv: enable dvb on Linux #30449

Merged
merged 1 commit into from Oct 17, 2017
Merged

mpv: enable dvb on Linux #30449

merged 1 commit into from Oct 17, 2017

Conversation

hhomar
Copy link
Contributor

@hhomar hhomar commented Oct 15, 2017

Motivation for this change

Since updating to 17.09, I can no longer use my tv tuner card with mpv. This will enable dvb support again on Linux.

I've verified that Arch Linux, Debian and Fedora enable this flag.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 17, 2017

Was this enabled in mpv in 17.03?

@Mic92 Mic92 merged commit e48154d into NixOS:master Oct 17, 2017
@fpletz
Copy link
Member

fpletz commented Oct 17, 2017

Backported to 17.09: 8a732c2

@hhomar
Copy link
Contributor Author

hhomar commented Oct 17, 2017

Looks like it is disabled by default starting from 0.26:

https://git.srsfckn.biz/mpv/commit/?id=99cef59fc9a4d33ebbbb4405ec86faf0ff213f0c

I didn't have any problem compiling it against 4.9.56, so I don't know how old the kernel would need to be for it not to compile. Probably older than what is in 17.09.

@Mic92
Copy link
Member

Mic92 commented Oct 17, 2017

Our kernel headers are the same for builds except for kernel modules, hence deterministic.

@hhomar hhomar deleted the mpv-enable-dvb-linux branch February 8, 2018 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants