Ensure FormData::Builder field value is a String #5129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
reviewed
Oct 16, 2017
| end | ||
|
|
||
| # Adds a form part called *name*, with data from *io* as the value. | ||
| # *Metadata* can be provided to add extra metadata about the file to the | ||
| # Content-Disposition header for the form part. Other headers can be added | ||
| # using *headers*. | ||
| def file(name, io, metadata : FileMetadata = FileMetadata.new, headers : HTTP::Headers = HTTP::Headers.new) | ||
| def file(name : String, io, metadata : FileMetadata = FileMetadata.new, headers : HTTP::Headers = HTTP::Headers.new) |
There was a problem hiding this comment.
why not also restrict io : IO?
There was a problem hiding this comment.
I mean, if not putting a type restriction led to a bug, we should always put type restrictions when possible.
asterite
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See RX14/multipart.cr#7.
fieldcould be passed an integer, which meant the incorrectIO::Memory.newoverload was chosen. I chose to fix this by callingto_son the result, but we could also make this more explicit by restricting to an IO.