epsxe: init at 2.0.5 #29810
Merged
epsxe: init at 2.0.5 #29810
+58
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 26, 2017
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = http://epsxe.com/; | ||
| license = licenses.unfree; |
There was a problem hiding this comment.
Definitely. In a few minutes.
lukateras
force-pushed
the
epsxe/init
branch
from
5ccbd9f to
7e27153
Compare
Mic92
reviewed
Sep 26, 2017
| dontStrip = true; | ||
|
|
||
| installPhase = '' | ||
| mv epsxe_* epsxe || true |
There was a problem hiding this comment.
Why should this fail?
Update is it different on 64bit?
There was a problem hiding this comment.
On i686-linux, the executable is already called epsxe. I probably could change this to mv epsxe* epsxe.
|
Thanks a lot! |
globin
pushed a commit
that referenced
this pull request
Sep 26, 2017
* epsxe: init at 2.0.5 * epsxe: nitpicks (cherry picked from commit 0ddca07)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)