Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epsxe: init at 2.0.5 #29810

Merged
merged 2 commits into from Sep 26, 2017
Merged

epsxe: init at 2.0.5 #29810

merged 2 commits into from Sep 26, 2017

Conversation

lukateras
Copy link
Member

@lukateras lukateras commented Sep 26, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Sep 26, 2017
View reviewed changes
pkgs/misc/emulators/epsxe/default.nix Outdated

meta = with stdenv.lib; {
homepage = http://epsxe.com/;
license = licenses.unfree;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a description?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely. In a few minutes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Mic92
Mic92 reviewed Sep 26, 2017
View reviewed changes
pkgs/misc/emulators/epsxe/default.nix Outdated
dontStrip = true;

installPhase = ''
mv epsxe_* epsxe || true
Copy link
Member

@Mic92 Mic92 Sep 26, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should this fail?
Update is it different on 64bit?

Copy link
Member Author

@lukateras lukateras Sep 26, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On i686-linux, the executable is already called epsxe. I probably could change this to mv epsxe* epsxe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make it explicit

@Mic92 Mic92 merged commit 0ddca07 into NixOS:master Sep 26, 2017
@lukateras
Copy link
Member Author

Thanks a lot!

@lukateras lukateras deleted the epsxe/init branch September 26, 2017 19:23
globin pushed a commit that referenced this pull request Sep 26, 2017
@lukateras @globin
epsxe: init at 2.0.5 (#29810)
2de0784 
* epsxe: init at 2.0.5

* epsxe: nitpicks

(cherry picked from commit 0ddca07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukateras @Mic92