Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: fix build wrt. new postgres.dev build output #29794

Merged
merged 1 commit into from Sep 26, 2017
Merged

php: fix build wrt. new postgres.dev build output #29794

merged 1 commit into from Sep 26, 2017

Conversation

stesie
Copy link
Member

@stesie stesie commented Sep 26, 2017 •
edited

Refs commit b0280f5

Motivation for this change

Build of PHP is broken due to change b0280f5

pg-config script has been moved to new build output "dev"

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

refs #29726

@mention-bot
Copy link

@stesie, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @dezgeg and @globin to be potential reviewers.

Mic92 referenced this pull request Sep 26, 2017
@edolstra
postgresql: Add dev output
b0280f5 
This reduces the closure size of postgresql.out by 72 MiB.
@stesie
Copy link
Member Author

stesie commented Sep 26, 2017

anyone got an idea what's going wrong on travis?

checking for LDAP support... yes
checking for LDAP Cyrus SASL support... /nix/store/s2p90ypc87czsm5kicyxc2ija0jdy9zi-cyrus-sasl-2.1.26-dev
checking size of long int... 8
configure: error: Cannot find ldap libraries in /usr/lib.
builder for ‘/nix/store/cp4b4zwxc3lpcradsm67cc465hhyghqm-php-5.6.31.drv’ failed with exit code 1
error: build of ‘/nix/store/cp4b4zwxc3lpcradsm67cc465hhyghqm-php-5.6.31.drv’ failed

... locally nox-review just compiled php56 fine

@Mic92
Copy link
Member

Mic92 commented Sep 26, 2017 •
edited

I just compile it locally and will ignore travis, if it compiles for me.

@Mic92 Mic92 merged commit 9c55fb1 into NixOS:master Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stesie @mention-bot @Mic92