webkitgtk: 2.16.6 -> 2.18.0 #29796
webkitgtk: 2.16.6 -> 2.18.0 #29796
Conversation
| @@ -79,7 +79,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| # XXX: WebKit2 missing include path for gst-plugins-base. | |||
| # Filled: https://bugs.webkit.org/show_bug.cgi?id=148894 | |||
| NIX_CFLAGS_COMPILE = "-I${gst-plugins-base.dev}/include/gstreamer-1.0" | |||
| NIX_CFLAGS_COMPILE = "-I${gst-plugins-base.dev}/include/gstreamer-1.0 -I${gst-plugins-bad}/include/gstreamer-1.0" | |||
There was a problem hiding this comment.
This should not be necessary, the bug was already fixed, see jtojnar@3b4df8d
There was a problem hiding this comment.
I'm a bit confused: In your update branch, you leave the build flag in: jtojnar@99796a4
I'll push the workaround for now, since that's what built for me, but I would like to incorporate your cleanup.
There was a problem hiding this comment.
I am not removing it since it was already removed in aebae6c
There was a problem hiding this comment.
Yep, that should have rang a bell. I was just stupid. I'd even been thinking about this needing to go to staging, yet, it didn't occur to me, to look there.
pkgs/top-level/all-packages.nix
Outdated
|
|
||
| webkitgtk24x-gtk3 = callPackage ../development/libraries/webkitgtk/2.4.nix { | ||
| harfbuzz = harfbuzz-icu; | ||
| gst-plugins-base = gst_all_1.gst-plugins-base; | ||
| inherit (darwin) libobjc; | ||
| }; | ||
|
|
||
| webkitgtk216x = callPackage ../development/libraries/webkitgtk/2.16.nix { | ||
| webkitgtk217x = callPackage ../development/libraries/webkitgtk/2.17.nix { |
There was a problem hiding this comment.
2.17 is unstable version of 2.18. As such, it can be removed.
fpletz
added
8.has: package (update)
9.needs: port to stable
bendlas
force-pushed
the
update-webkitgtk
branch
from
df7cb70
to
56f3648
Compare
remove references to 216x
bendlas
force-pushed
the
update-webkitgtk
branch
from
56f3648
to
cbfeb4d
Compare
|
Sorry, I just saw that this already went to staging. I reverted the commit to master. Still, staging should be updated to 2.18.2 |
Motivation for this change
stable update
Things done
update dependents
just built, will test when I get home
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)