bash-supergenpass: init at 2012-11-02 #29797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
force-pushed
the
bash-supergenpass
branch
from
de79f54
to
9c62c1a
Compare
Mic92
reviewed
Sep 26, 2017
| description = "Bash shell-script implementation of SuperGenPass password generation"; | ||
| longDescription = '' | ||
| Bash shell-script implementation of SuperGenPass password generation | ||
| Usage: ./supergenpass.sh <domain> [ <length> ] |
There was a problem hiding this comment.
This looks more like a manual then a description. Do you want to keep it that way?
There was a problem hiding this comment.
Well, bash-supergenpass does not have an --help argument, so I put the usage there. Is there a more appropriate place where to put it?
|
The choice of the hash algorithm seems a little bit strange to me: https://github.com/lanzz/bash-supergenpass/blob/master/supergenpass.sh#L12 I would have chosen something like bcrypt or PBKDF2 at least. |
|
@Mic92 yeah, the algorithm is not the best but It's the one used by supergenpass. https://oneshallpass.com/ is probably the ideal solution, but it lacks implementations (eg for android or sailfish or lightweight linux cli), while sgp has them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the bash implementation of supergenpass.com, since no other implementation is present in nixpkgs
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)The only thing I'm not sure of is whether to include or not the dependencies (
openssletc) inbuildInputs.